Update input_step.md #2365
Merged
Update input_step.md #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pipelines
|
Preview URL: https://2365--bk-docs-preview.netlify.app |
|
@mbelton-buildkite Please can you review this PR and share your feedback |
@mbelton-buildkite Gentle remainder on this review request |
pages/pipelines/input_step.md
Outdated
| @@ -44,6 +44,8 @@ For an example pipeline, see the [Input step example pipeline](https://github.c | |||
|
|
|||
| <a class="Docs__example-repo" href="https://github.com/buildkite/input-step-example"><span class="detail">:pipeline: Input Step Example Pipeline</span> <span class="repo">github.com/buildkite/input-step-example</span></a> | |||
|
|
|||
| >📘 Input step should not be used to store sensitive information like secrets. | |||
There was a problem hiding this comment.
I think we should use the warning format for this, and separate out a title from the body text. In the body, it would be good to add the reason why you shouldn't do this. Please correct this, but thinking something like:
Suggested change
| >📘 Input step should not be used to store sensitive information like secrets. | |
| >🚧 Don't store sensitive data in input steps | |
| > You shouldn't use input steps to store sensitive information like secrets because the data is available in subsequent steps. |
There was a problem hiding this comment.
@mbelton-buildkite Updated with suggestion but with slight modification to see data will be stored in build metadata
mbelton-buildkite
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR is to add a note to let users know that input step fields should not be used to pass secret information