-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc 654 add reference to queues on branch configurations #2392
Doc 654 add reference to queues on branch configurations #2392
Conversation
I'll need to sleep on this one. It's useful information that I think we should include, but it's not clear if this is the right way to go about it. I believe the proper place to draw this connection is on an explanation page that talks about controlling when and where jobs run on agents. But I don't believe that page exists. Without that, I see three ways to incorporate it on these pages:
I'm leaning towards 3. What do you think? |
I think 3 is the way to go, with a new section "## Alternative methods" at the end of the page. I won't have time to look at it today, but can help tomorrow. |
Thanks Will do 👍 |
can you re -review @mbelton-buildkite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more tweak and then I think it'll be good to go
Co-authored-by: Michael Belton <119824349+mbelton-buildkite@users.noreply.github.com>
Co-authored-by: Michael Belton <119824349+mbelton-buildkite@users.noreply.github.com>
Purpose of this was to add Agent Queues as an alternative way of filtering pipelines and steps from being done – and where (agents) they are completed.
Then I added another example to the
Queues
page so it was clear thequeue
YAML attribute could be used as either root level or on a specific step.Then I added a reference to branch filtering from the Queues page for completeness.
QUERY: I wasn't sure about referencing things as either 'build steps' or 'jobs'. It differs page to page. Welcome your input @mbelton-buildkite