Feature: Add Support for Buildless #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgammon
changed the title
sgammon
commented
Nov 28, 2023
| @@ -2,7 +2,7 @@ | |||
| edition = "2021" | |||
| name = "sccache" | |||
| rust-version = "1.67.1" | |||
| version = "0.7.4" | |||
| version = "0.7.5-buildless" | |||
There was a problem hiding this comment.
released under a custom version, for now
Comment on lines
+180
to
+182
| BuildlessTransport::AUTO => build_https(do_use_agent, endpoint, apikey, &agent_config), | ||
| BuildlessTransport::HTTPS => build_https(do_use_agent, endpoint, apikey, &agent_config), | ||
| BuildlessTransport::RESP => build_resp(do_use_agent, endpoint, apikey), |
| "gha", | ||
| "webdav", | ||
| ] | ||
| azure = ["opendal", "reqsign"] | ||
| buildless = ["opendal", "redis", "webdav"] |
There was a problem hiding this comment.
since buildless implements webdav and redis, this code simply reuses those adapters to reduce code surface
sgammon
force-pushed
the
feat/buildless
branch
from
c63a239
to
2958a52
Compare
sgammon
commented
Nov 28, 2023
Comment on lines
+740
to
+741
| // ======= Buildless ======= | ||
| let buildless = if env::var("SCCACHE_BUILDLESS").is_ok() || env::var("BUILDLESS_APIKEY").is_ok() | ||
| { | ||
| // read kill switch | ||
| let enable_var = env::var("SCCACHE_BUILDLESS").ok().unwrap_or_default(); |
There was a problem hiding this comment.
buildless takes last precedence over all other adapters (except fallback to local disk), to prevent conflicts with providers which expect to fail with incomplete config.
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
- feat(buildless): add configuration structures for buildless - feat(buildless): implement cache backend for buildless, using webdav - feat(buildless): implement cache backend for buildless, using redis - feat(buildless): implement agent detection and use (where enabled) - feat(buildless): decode agent config and use specified port - fix(buildless): don't use control port for cache traffic - docs(buildless): add `docs/Buildless` and root README references Signed-off-by: Sam Gammon <sam@elide.ventures>
- test(buildless): add integration test for `buildless-cloud` - test(buildless); add integration test for `buildless-agent` Signed-off-by: Sam Gammon <sam@elide.ventures>
sgammon
force-pushed
the
feat/buildless
branch
from
2958a52
to
58e8cb2
Compare
Signed-off-by: Sam Gammon <sam@elide.ventures>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Draft PR which adds Buildless support to
sccache. If this goes well, later, we can maybe upstream it.Task list
sccachebackendBUILDLESS_APIKEYsccacheand Buildlesssccachesccachereadmesccacheintegrationsccachefork and featuresccache+buildlesscloudsccache+buildlessagentsccachesccachesccachein releases of thebuildlessCLIChangelog
docs/Buildlessand root README references