Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: Replace exportloopref by copyloopvar and intrange #1434

Merged
merged 2 commits into from
Dec 3, 2024
Merged

lint: Replace exportloopref by copyloopvar and intrange #1434

merged 2 commits into from
Dec 3, 2024

Conversation

gogolok
Copy link
Contributor

@gogolok gogolok commented Dec 3, 2024

Summary

The golangci-lint linter exportloopref is deprecated. As far as I understood, it can be replaced by the linters copyloopvar and intrange

$ make lint
> Installing golangci-lint...
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.61.0
> Linting code...
WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.

@gogolok
exportloopref: deprecation
23922f4 
Signed-off-by: Robert Gogolok <robert.gogolok@stackit.cloud>
@gogolok
copyloopvar: Fix linter errors
32f1113 
Signed-off-by: Robert Gogolok <robert.gogolok@stackit.cloud>
@gogolok gogolok requested a review from a team as a code owner December 3, 2024 09:15
@jabrown85 jabrown85 merged commit 8cfa351 into buildpacks:main Dec 3, 2024
7 checks passed
@gogolok gogolok deleted the loop_deprecation branch December 5, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabrown85 jabrown85 jabrown85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gogolok @jabrown85