Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides client keychain to lifecycle instead of the default keychain #1872

Merged
merged 3 commits into from
Aug 26, 2023

Conversation

natalieparellano
Copy link
Member

Fixes #1845

Summary

Provides client keychain to lifecycle instead of the default keychain

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #1845

Fixes #1845

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano requested review from a team as code owners August 23, 2023 17:54
@github-actions github-actions bot added this to the 0.31.0 milestone Aug 23, 2023
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Aug 23, 2023
@jkutner jkutner enabled auto-merge August 26, 2023 13:13
@jkutner jkutner merged commit 0562a9d into main Aug 26, 2023
18 checks passed
@jkutner jkutner deleted the fix/client-withkeychain branch August 26, 2023 16:17
@jjbustamante jjbustamante modified the milestones: 0.31.0, 0.30.1 Sep 12, 2023
@jjbustamante jjbustamante added type/bug Issue that reports an unexpected behaviour. and removed type/enhancement Issue that requests a new feature or improvement. labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix client.WithKeychain to use it during the lifecycle
3 participants