Adding support for reading docker context #1878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support to Pack for reading the
docker HOST
, to be used during the application build, from the current docker context saved at the home user directory.Output
Before
When running
pack build
on Linux with Docker desktop installed, the following error was thrown:Initially, this error could be workaround by:
sudo ln -s $HOME/.docker/desktop/docker.sock /var/run/docker.sock
DOCKER_HOST=unix://$HOME/.docker/desktop/docker.sock /var/run/docker.sock
environment variableAfter
Currently my docker context configuration is:
I used to have the symlink but I removed it, now running
pack build
, pack will read from my local docker configuration file thatdesktop-liinux
context is being used and then read the endpoint host from there and use it during the build, removing the previous errorDocumentation
Related
Resolves #1759
Resolves #1830