Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Noble Numbat #2107

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Release Noble Numbat #2107

merged 2 commits into from
Mar 27, 2024

Conversation

a1flecke
Copy link
Contributor

@a1flecke a1flecke commented Mar 21, 2024

Ubunut has pushed out a docker image for Noble. There is not a pack cli in buildpacks launchpad for Noble

Summary

  • Update Github workflows to release a package for Ubuntu 22.04 (Noble Numbat)

Output

Upload pack to the buildpacks PPA launchpad for Noble

Before

  • No package existed for Noble

After

  • Package exists for Noble

Documentation

  • Should this change be documented?
    • Yes, see #___
    • [x ] No

Related

Resolves #2152

@a1flecke a1flecke requested review from a team as code owners March 21, 2024 18:01
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Mar 21, 2024
@github-actions github-actions bot added this to the 0.34.0 milestone Mar 21, 2024
@rmacconn
Copy link

We are going to need this soon also. This is great.

Copy link
Member

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @a1flecke

It looks good to me according to how previously we extended support for other ubuntu versions.

@a1flecke
Copy link
Contributor Author

@jjbustamante thanks for the review. Is anything else needed before this lands? I was prompted to create this because Ubuntu has already pushed out the Noble image. This has resulted in our dependency updater creating broken PRs for our engineers' projects due to pack-cli not being available yet

- Update Github workflows to release a package for Ubuntu 22.04 (Noble Numbat)

Signed-off-by: Aaron Fleckenstein <aaron.fleckenstein@daveramsey.com>
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.01%. Comparing base (ad6673d) to head (c2fcc53).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2107      +/-   ##
==========================================
- Coverage   79.72%   79.01%   -0.71%     
==========================================
  Files         176      176              
  Lines       13263    13263              
==========================================
- Hits        10573    10478      -95     
- Misses       2021     2118      +97     
+ Partials      669      667       -2     
Flag Coverage Δ
os_linux 78.63% <ø> (ø)
os_macos 76.36% <ø> (ø)
os_windows 78.35% <ø> (-0.76%) ⬇️
unit 79.01% <ø> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jjbustamante jjbustamante merged commit 9dafd73 into buildpacks:main Mar 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation of pack-cli on Ubuntu 24.04 LTS fails
3 participants