🔫 add tests for handler

build.sh

@@ -14,4 +14,5 @@ set -o xtrace
 __dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 docker-compose build dev
+docker-compose run --rm dev npm test
 docker-compose run --rm dev npm run build

package.json

@@ -5,7 +5,7 @@
   "scripts": {
     "build": "npx gulp",
     "clean": "npx gulp clean",
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "npx mocha"
   },
   "repository": {
     "type": "git",
@@ -20,11 +20,14 @@
   "devDependencies": {
     "@babel/core": "^7.2.2",
     "@babel/preset-env": "^7.3.1",
+    "chai": "^4.2.0",
     "gulp": "^4.0.0",
     "gulp-babel": "^8.0.0",
     "gulp-cli": "^2.0.1",
     "gulp-concat": "^2.6.1",
     "gulp-uglify": "^3.0.1",
-    "rimraf": "^2.6.3"
+    "mocha": "^5.2.0",
+    "rimraf": "^2.6.3",
+    "sinon": "^7.2.3"
   }
 }

src/basic-auth.js

@@ -22,13 +22,14 @@ exports.handler = (event, context, callback) => {
         'www-authenticate': [
           {
             key: 'WWW-Authenticate',
-            value:'Basic',
+            value: 'Basic',
           }
         ]
       },
     }
 
     callback(null, response)
+    return
   }
 
   // Continue request processing if authentication passed

test/basic-auth.test.js

@@ -0,0 +1,121 @@
+const expect = require('chai').expect
+const sinon = require('sinon')
+const { handler } = require('../src/basic-auth')
+
+describe('Basic Auth', function() {
+  describe('handler', function () {
+    it('should return 401 and WWW-Authenticate: Basic header without Authorization header', function() {
+      const event = {
+        Records: [
+          {
+            cf: {
+              request: {
+                headers: {
+                },
+              },
+            },
+          },
+        ],
+      }
+
+      const callback = sinon.fake()
+
+      handler(event, null, callback)
+
+      expect(callback.calledOnce).to.be.true
+
+      const [ err, response ] = callback.args[0]
+
+      expect(err).to.be.null
+      expect(response).to.have.property('status', '401')
+      expect(response).to.have.property('headers')
+
+      const { headers } = response
+
+      expect(headers).to.have.property('www-authenticate')
+
+      expect(headers['www-authenticate']).to.deep.equal([
+        {
+          key: 'WWW-Authenticate',
+          value: 'Basic',
+        },
+      ])
+    })
+
+    it('should return 401 and WWW-Authenticate: Basic header if authentication failed', function() {
+      const event = {
+        Records: [
+          {
+            cf: {
+              request: {
+                headers: {
+                  authorization: [
+                    {
+                      // new Buffer('impossible:impossible').toString('base64')
+                      value: 'Basic aW1wb3NzaWJsZTppbXBvc3NpYmxl',
+                    },
+                  ],
+                },
+              },
+            },
+          },
+        ],
+      }
+
+      const callback = sinon.fake()
+
+      handler(event, null, callback)
+
+      expect(callback.calledOnce).to.be.true
+
+      const [ err, response ] = callback.args[0]
+
+      expect(err).to.be.null
+      expect(response).to.have.property('status', '401')
+      expect(response).to.have.property('headers')
+
+      const { headers } = response
+
+      expect(headers).to.have.property('www-authenticate')
+
+      expect(headers['www-authenticate']).to.deep.equal([
+        {
+          key: 'WWW-Authenticate',
+          value: 'Basic',
+        },
+      ])
+    })
+
+    it('should return request if authentication succeeded', function() {
+      const event = {
+        Records: [
+          {
+            cf: {
+              request: {
+                headers: {
+                  authorization: [
+                    {
+                      // new Buffer('${user}:${password}').toString('base64')
+                      value: 'Basic JHt1c2VyfToke3Bhc3N3b3JkfQ==',
+                    },
+                  ],
+                },
+              },
+            },
+          },
+        ],
+      }
+
+      const callback = sinon.fake()
+
+      handler(event, null, callback)
+
+      expect(callback.calledOnce).to.be.true
+
+      const [ err, response ] = callback.args[0]
+
+      expect(err).to.be.null
+      expect(response).to.deep.equal(event.Records[0].cf.request)
+    })
+  })
+})