Update libraries #716
Update libraries #716
Conversation
| @@ -49,7 +49,8 @@ internal class ChildNodeCreationManager<NavTarget : Any>( | |||
| when (keepMode) { | |||
| ChildEntry.KeepMode.KEEP -> { | |||
| navModelKeepKeys = | |||
| (state.onScreen + state.offScreen).mapNotNullToSet { element -> element.key } | |||
| state.onScreen.mapNotNullToSet { element -> element.key } + | |||
There was a problem hiding this comment.
The Kotlin compiler reeeeeeally doesn't like (state.onScreen + state.offScreen)
I assume it has something to do with the generics, but even after attempting to change a lot of code to use : Any it still didn't work 🤔
There was a problem hiding this comment.
those are 2 lists of the same type, looks like a compiler bug
There was a problem hiding this comment.
at least there was a workaround 🫠
There was a problem hiding this comment.
Does set + set create a new set or a collection?
There was a problem hiding this comment.
a new set.
the definition of navModelKeepKeys is val navModelKeepKeys: Set<NavKey<NavTarget>> so it wouldn't compile unless it returned a set.
| ChildRenderer, | ||
| TransitionDescriptor<NavTarget, State> |
There was a problem hiding this comment.
This is no longer allowed in Kotlin 2.0
https://developer.android.com/jetpack/androidx/releases/compose-compiler#1.5.0
Named arguments for @Composable lambda calls have been deprecated. This feature is relying on internal compiler APIs and will not be supported by K2.
| androidTestImplementation(composeBom) | ||
| androidTestImplementation(libs.androidx.test.espresso.core) | ||
| androidTestImplementation(libs.androidx.test.junit) | ||
| androidTestImplementation(libs.compose.ui.test.junit4) |
There was a problem hiding this comment.
There are no tests in this module (maybe there should be?)
LachlanMcKee
force-pushed
the
chore-update-libs
branch
from
711343e
to
9d61c45
Compare
LachlanMcKee
force-pushed
the
chore-update-libs
branch
from
3b283eb
to
2786dfa
Compare
Description
Updated Kotlin, Compose Compiler (implicitly via Kotlin) and several Androidx libs
Check list
CHANGELOG.mdif required.