Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startup: load configuration (public key) at startup time #10

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

paulRbr
Copy link
Member

@paulRbr paulRbr commented Nov 25, 2024

This commit moves the parsing of the public key configuration during
the loading of the proxy file (instead of during runtime while a
request is made to the proxy).

This commit moves the parsing of the public key configuration during
the loading of the proxy file (instead of during runtime while a
request is made to the proxy).
@paulRbr paulRbr self-assigned this Nov 25, 2024
Copy link
Contributor

@hack3rvaillant hack3rvaillant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice way of failing early. This is smart. Thank you.
I hope this will prevent future bad copy/paste of keys

@hack3rvaillant hack3rvaillant merged commit acf8425 into bump-sh:main Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants