Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure to verify only path value (and not query params) #11

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: make sure to verify only path value (and not query params) #11

merged 1 commit into from
Nov 25, 2024

Conversation

paulRbr
Copy link
Member

@paulRbr paulRbr commented Nov 25, 2024

This commit makes sure to verify the target path without query
parameters when verifying the JWT token.

@paulRbr
fix: make sure to verify only path value (and not query params)
ed063a6 
This commit makes sure to verify the target path without query
parameters when verifying the JWT token.
hack3rvaillant
hack3rvaillant approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@hack3rvaillant hack3rvaillant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the query parameters

@hack3rvaillant hack3rvaillant merged commit 1046d84 into bump-sh:main Nov 25, 2024
1 check passed
@paulRbr paulRbr deleted the fix-path-verification branch November 25, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hack3rvaillant hack3rvaillant hack3rvaillant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulRbr @hack3rvaillant