errors: add a catch-all handler #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This generic error handler helps to give context in case of target
server errors.
Indeed without this commit, the user of the proxy would see a `500
Internal server error`. Now, with the current change the real error is
catched and a 502 HTTP error is responded to the user, with some
details in a json object `{error: error.message}`.
E.g. when targeting a server which has a bad SSL certificate, the user
will now receive this response:
```
HTTP/1.1 502 Bad Gateway
access-control-allow-origin: *
access-control-allow-methods: OPTIONS
access-control-allow-methods: GET
access-control-allow-methods: POST
access-control-allow-methods: PUT
access-control-allow-methods: PATCH
access-control-allow-methods: DELETE
access-control-allow-headers: Content-Type, Authorization, x-bump-proxy-token, x-requested-with
content-type: application/json
x-content-type-options: nosniff
Content-Length: 127
{"error":"SSL_connect returned=1 errno=0 peeraddr=212.95.74.75:443 state=error: certificate verify failed (hostname mismatch)"}
```
This commits moves all “valid token” requests in the same context. It also moves the HTTP stubs inside the corresponding test context for clarity.
hack3rvaillant
approved these changes
Nov 25, 2024
|
Always good to know all the HTTP status codes! And indeed a 502 here is perfect. |
|
Well done @paulRbr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is in the first commit:
errors: add a catch-all handler to give feedback to the proxy user
This generic error handler helps to give context in case of target
server errors.
Indeed without this commit, the user of the proxy would see a
500 Internal server error. Now, with the current change the real error iscatched and a 502 HTTP error is responded to the user, with some
details in a json object
{error: error.message}.E.g. when targeting a server which has a bad SSL certificate, the user
will now receive this response:
Other changes