Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add CORS_TOUJOURS_TOKEN_HEADER env configuration #13

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

paulRbr
Copy link
Member

@paulRbr paulRbr commented Nov 27, 2024

This commit closes #7 by introducing a new optional
CORS_TOUJOURS_TOKEN_HEADER env variable configuration that allows a
proxy to use a custom named header for the JWT token.

The default value is x-cors-toujours-token if the env variable is
not set.

@paulRbr paulRbr self-assigned this Nov 27, 2024
@paulRbr paulRbr force-pushed the custom-token-header-name branch 2 times, most recently from 318dd35 to 725b624 Compare November 27, 2024 15:40
@paulRbr
Copy link
Member Author

paulRbr commented Nov 29, 2024

friendly ping @hack3rvaillant, could you please review the PR?

proxy_server.rb Show resolved Hide resolved
This commit closes #7 by introducing a new optional
`CORS_TOUJOURS_TOKEN_HEADER` env variable configuration that allows a
proxy to use a custom named header for the JWT token.

The default value is `x-cors-toujours-token` if the env variable is
not set.
@paulRbr paulRbr force-pushed the custom-token-header-name branch from 725b624 to 637ead2 Compare November 29, 2024 19:22
@paulRbr
Copy link
Member Author

paulRbr commented Nov 29, 2024

Thanks for the review 🙇

@paulRbr paulRbr merged commit 3de70d9 into bump-sh:main Nov 29, 2024
1 check passed
@paulRbr
Copy link
Member Author

paulRbr commented Nov 29, 2024

ℹ️ I've setup the CORS_TOUJOURS_TOKEN_HEADER_NAME env variable in both our staging and prod proxies ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the x-bump-proxy-token header name into a configurable name
2 participants