readme: clarify usage of the JWT private key #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saying that the client is using the private key isn't really clear. Indeed the private key is not used by the browsers client, but the server “client”. I tried to clarify this by modifying the sentence. Let me know if you have a better phrasing.
|
I think that it depends of the use case. If you have a SPA there it could be only on the client side. CORS proxies are really useful for SPAs. |
hack3rvaillant
approved these changes
Dec 11, 2024
What I meant is that you wouldn't want a private key to be included in a web client (be it a SPA or not) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saying that the client is using the private key isn't really
clear. Indeed the private key is not used by the browsers client, but
the server “client”.
I tried to clarify this by modifying the sentence.
Let me know if you have a better phrasing.