Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH workflow #8

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Add GH workflow #8

merged 1 commit into from
Nov 7, 2024

Conversation

hack3rvaillant
Copy link
Contributor

@hack3rvaillant hack3rvaillant commented Nov 7, 2024

Add CI Pipeline & Simplify Key Rotation

Changes

🔄 Added GitHub Actions Workflow

  • Set up continuous integration pipeline running on:
    • Push to main branch
    • Pull requests targeting main
  • Pipeline steps:
    1. Checkout code
    2. Configure Ruby environment with bundler cache
    3. Execute key rotation script
    4. Run RSpec test suite

🔑 Simplified Key Rotation Script

  • Removed redundant environment variable cleanup
  • Keys are now appended to .env file without prior deletion
  • Maintains same RSA key generation functionality

Why

  • Automated testing ensures code quality and prevents regressions
  • Simplified key rotation reduces potential file manipulation issues
  • CI integration helps catch issues early in the development cycle

Testing Done

The changes have been verified by:

  • Running the modified key rotation script locally
  • Confirming GitHub Actions workflow executes successfully
  • Validating RSpec test execution in CI environment

Notes

  • No changes to core application logic
  • CI pipeline uses Ubuntu latest for consistent build environment
  • Key rotation still generates both public and private RSA keys

@hack3rvaillant hack3rvaillant marked this pull request as ready for review November 7, 2024 10:20
@hack3rvaillant hack3rvaillant force-pushed the run-ci-before-merge branch 6 times, most recently from da23fef to c7def41 Compare November 7, 2024 10:53
rotake_keys.rb Outdated Show resolved Hide resolved
Copy link
Member

@paulRbr paulRbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for the automated tests that will help contributions on this project!

@hack3rvaillant hack3rvaillant merged commit 0a6d1b6 into main Nov 7, 2024
1 check passed
@paulRbr paulRbr deleted the run-ci-before-merge branch December 12, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants