Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slice_cfr #194

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

slice_cfr #194

wants to merge 20 commits into from

Conversation

yffbit
Copy link
Contributor

@yffbit yffbit commented Apr 16, 2024

slice_cfr traverses the tree using slice structure rather than dfs method, so it's easier to change to CUDA code

@Takumi-trbl
Copy link

Takumi-trbl commented Apr 16, 2024 via email

@bupticybee
Copy link
Owner

I'm reviewing this. Thanks a lot for your impressive work in advance! Really looking forword for the CUDA version.

@bupticybee
Copy link
Owner

bupticybee commented Apr 17, 2024

Hey could you add a description on what environment is needed to compile this code? And could you add some statics if there is any on how performance changes before and after this slice method?

@bupticybee
Copy link
Owner

slice_cfr traverses the tree using slice structure rather than dfs method, so it's easier to change to CUDA code

Hey is it possible we talk through wechat? I want to discuss some other project that you are working on and future possible future cooperations. If you are interested in such a discussion, please add my wechat: 892009517 .

@bupticybee bupticybee mentioned this pull request Apr 17, 2024
@bupticybee
Copy link
Owner

截屏2024-04-17 16 19 46

I'm trying to get your code running on GUI, and it seems that now I'm unable to get a exploitability, and the memory usage doubled compare to baseline. Could you please check what happened?

@bupticybee
Copy link
Owner

Hi, CI failed on latest commit, do you mind check it a bit?

@yffbit
Copy link
Contributor Author

yffbit commented Jun 2, 2024

Hi, CI failed on latest commit, do you mind check it a bit?

install dependencies error, not compile error

E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/pool/main/g/gst-plugins-base1.0/libgstreamer-plugins-base1.0-0_1.16.3-0ubuntu1.2_amd64.deb  404  Not Found [IP: 52.252.75.106 80]
E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/pool/main/g/gst-plugins-base1.0/gstreamer1.0-plugins-base_1.16.3-0ubuntu1.2_amd64.deb  404  Not Found [IP: 52.252.75.106 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

@ShireGrin
Copy link

ShireGrin commented Oct 19, 2024

Hello, if the branch has no more issues, can it be merged ?

I also could help with some quality of life commits as i don't know much about algorithm but could help with the frontend maybe but i don't know how that would work

I would really like to make the solver better i am a web developer, i know c#, php, java, etc.

I have only once programmed in c++. I have been checking the source code a little bit, even tho i don't know much about algorithms regarding the solutions or optimizations, i could help with some quality of like improvements, you could maybe tell me things to do and i could work on them

@bupticybee
Copy link
Owner

Hello, if the branch has no more issues, can it be merged ?

I also could help with some quality of life commits as i don't know much about algorithm but could help with the frontend maybe but i don't know how that would work

I would really like to make the solver better i am a web developer, i know c#, php, java, etc.

I have only once programmed in c++. I have been checking the source code a little bit, even tho i don't know much about algorithms regarding the solutions or optimizations, i could help with some quality of like improvements, you could maybe tell me things to do and i could work on them

This branch still has unresolved issues. Both speed and accuracy is not verified, can't merge now.

@EvGid
Copy link

EvGid commented Oct 21, 2024

Hello, if the branch has no more issues, can it be merged ?
I also could help with some quality of life commits as i don't know much about algorithm but could help with the frontend maybe but i don't know how that would work
I would really like to make the solver better i am a web developer, i know c#, php, java, etc.
I have only once programmed in c++. I have been checking the source code a little bit, even tho i don't know much about algorithms regarding the solutions or optimizations, i could help with some quality of like improvements, you could maybe tell me things to do and i could work on them

This branch still has unresolved issues. Both speed and accuracy is not verified, can't merge now.

Make it to the mobile version of Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants