-
-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo redo buttons disabled state #555
Undo redo buttons disabled state #555
Conversation
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
@burhanrashid52 Do you remember about this PR? :) |
photoeditor/src/main/java/ja/burhanrashid52/photoeditor/PhotoEditor.kt
Outdated
Show resolved
Hide resolved
@@ -192,6 +192,9 @@ internal class PhotoEditorImpl @SuppressLint("ClickableViewAccessibility") const | |||
return mGraphicManager.redoView() | |||
} | |||
|
|||
override val redoStackCount: Int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we change this to a boolean then the logic moves here :
override val isRedoAvailable
get() = mGraphicManager.redoViewsCount > 0
We need to add similar function for undo as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Nop. It just got slipped 😆. Added review comments. |
@wasky I am planning to create a new |
Undo and redo buttons are now disabled if there is no undo or redo action available.