Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUAList Editor #22

Merged
merged 11 commits into from
Jul 26, 2022
Merged

LUAList Editor #22

merged 11 commits into from
Jul 26, 2022

Conversation

derneuere
Copy link
Contributor

@derneuere derneuere commented May 7, 2022

This pull request implements reading and writing the LUAList and the LUAList Entry.

I am not sure yet on how to test this. Any help figuring out when a LUAScript is used would be appreciated.

@burninrubber0
Copy link
Owner

As far as I know, the only ones accessible in the vanilla game are the Pass The Pad (Party) scripts. The others are for a cut feature called scripted challenges. That's been accessed by a few people but there's still no public way of running them.

Testing should be easy enough through Party mode, but it might take a while to land on a specific script.

@derneuere
Copy link
Contributor Author

Oh no, that means I can't test it, as online mode never worked for me. I always have to play in offline mode, otherwise the game crashes 😅

@burninrubber0
Copy link
Owner

Yikes, might want to contact Bo about that. There's also this updated version of the Core Bugfixes you should try after installing the normal version through BPR Modder - it weeds out most of the bugs I know about.
core-bugfixes.zip

@derneuere
Copy link
Contributor Author

derneuere commented May 8, 2022

I figured out why it wasn't working! I had a couple of friends who deleted their accounts and bpr could not handle that. Would be great if this could be fixed in a future core bugfix release.

Edit: Alright, it's logged here: Bo98/bpr-bugs#54

@burninrubber0
Copy link
Owner

Finally got the chance to test this. It works but ends up feeling super clunky. Lots of padding, pointers, and lengths showing up when they should all be hidden and automatically taken care of. Also still needs CgsIDs to be decoded, looks like.

I'd say this is a good starting point for testing whether it saves properly and such, but a custom editor is needed for it to be worthwhile - perhaps similar to the VehicleList editor (but smaller, because the VehicleList is massive).

@burninrubber0 burninrubber0 mentioned this pull request May 16, 2022
@derneuere
Copy link
Contributor Author

Alright, I have removed all paddings, pointers and lengths, and they should get taken care of automatically. I also replaced all unknown fields with the types defined in the specification.

The UI is now functional enough for now, and I want to finish the other PRs first. I will then address UI concerns in a future PR.

Copy link
Owner

@burninrubber0 burninrubber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks complete and accurate now, nice work.

The one thing I noticed was the type and variables fields in entries are displayed as integers when they're really binary flags, but looking at them now I think any changes to them are best left for another PR.

Merging.

@burninrubber0 burninrubber0 merged commit 9f11fdc into burninrubber0:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants