Fix a printf format string signedness warning #724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc 13.2 outputs several warnings for mismatched printf format strings, such as:
This patch doesn't fix all of them, but does fix the simple ones. The more complicated ones include signedness issues with '%X' in the sav_compare test, which would either require a rework of the signedness of a whole bunch of code, or a hacky cast:
There's also a warning about the format string not being a literal in the screenshot code, which would probably require a more clever fix:
All of these are pretty harmless, so it's not particularly important that all (or any) of them actually get fixed. But it's nice to remove a warning if we can. :-)