Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joss review benjamin #152

Closed
wants to merge 3 commits into from
Closed

Joss review benjamin #152

wants to merge 3 commits into from

Conversation

bwheelz36
Copy link
Owner

Hi @benjaminbolling

I've made changes to your issues in this PR.
I will leave it open until you let me know you are satisfied with the responses!

@bwheelz36
Copy link
Owner Author

oops I didn't intent to include #144 in this - will make a new PR.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.07 ⚠️

Comparison is base (64478fd) 85.70% compared to head (2b67395) 85.64%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   85.70%   85.64%   -0.07%     
==========================================
  Files           8        8              
  Lines        1154     1156       +2     
==========================================
+ Hits          989      990       +1     
- Misses        165      166       +1     
Impacted Files Coverage Δ
ParticlePhaseSpace/__phase_space_config__.py 91.30% <ø> (ø)
ParticlePhaseSpace/_ParticlePhaseSpace.py 89.40% <66.66%> (-0.16%) ⬇️
ParticlePhaseSpace/DataLoaders.py 80.85% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bwheelz36 bwheelz36 closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants