PHP 8.1 Implementation #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teratorFilter::addRelationOr to IteratorFilter::or;
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to update PHP version compatibility, introduce new configurations, and refactor the codebase for better type safety and modern PHP practices. The most important changes include updating the PHP versions in the PHPUnit workflow, adding new run configurations, and refactoring code to use stricter type declarations and enums.
PHP Version and Configuration Updates:
.github/workflows/phpunit.yml: Updated the PHP versions matrix to include "8.3" and removed "8.0" and "7.4".New Run Configurations:
.run/PSalm.run.xml: Added a new run configuration for PSalm..run/Test Project.run.xml: Added a new run configuration for PHPUnit.Codebase Refactoring:
composer.json: Updated PHP requirement to ">=8.1" and updated dependencies to newer versions. Addedautoload-devfor test namespaces.src/AnyDataset.php: Refactored class to use strict types, updated method signatures, and replaced deprecated methods. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]src/Enum/Relation.php: ConvertedRelationclass to an enum for better type safety.Other Improvements:
example.php: Updated method call to useandinstead ofaddRelation.src/Formatter/BaseFormatter.php,src/Formatter/FormatterInterface.php,src/Formatter/JsonFormatter.php: Updated method signatures to use strict types and added type hints. [1] [2] [3] [4]These changes collectively improve the codebase by ensuring compatibility with newer PHP versions, adding helpful configurations for development, and enforcing stricter type safety throughout the code.