Skip to content

Commit

Permalink
Ignore spidermonkey rebuild with a "skip list"
Browse files Browse the repository at this point in the history
The `spidermonkey` build failures are already captured in #231.
  • Loading branch information
abrown committed Jun 14, 2023
1 parent 1462e79 commit c3d90b1
Showing 1 changed file with 13 additions and 4 deletions.
17 changes: 13 additions & 4 deletions benchmarks/build-all.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
# Either build all of the benchmarks or a random subset of them.
#
# Usage: ./build-all.sh <number of benchmarks>
# - <number of benchmarks>, an optional number of benchmarks to build; if provided, this script will
# randomize the list of benchmarks and pick a subset of them to build
# - <number of benchmarks>, an optional number of benchmarks to build; if
# provided, this script will randomize the list of benchmarks and pick a
# subset of them to build

set -e
# From https://stackoverflow.com/a/246128:
Expand All @@ -13,8 +14,16 @@ BENCHMARKS_DIR=$(realpath $SCRIPT_DIR)
BUILD_SCRIPT=$BENCHMARKS_DIR/build.sh
DOCKERFILES=$(find $BENCHMARKS_DIR -name Dockerfile)

# If a numeric parameter `N` is provided to the script (e.g., `./build-all.sh 5`), randomly select
# `N` benchmarks to rebuild; otherwise, rebuild all benchmarks.
# Some benchmarks have known rebuild failures but are still useful to retain.
# This "skip list" prevents them from being considered for rebuilding.
SKIPLIST=("spidermonkey")
for SKIP in $SKIPLIST; do
DOCKERFILES=$(echo $DOCKERFILES | sed -e "s+$BENCHMARKS_DIR/$SKIP/Dockerfile++")
done

# If a numeric parameter `N` is provided to the script (e.g., `./build-all.sh
# 5`), randomly select `N` benchmarks to rebuild; otherwise, rebuild all
# benchmarks.
re='^[0-9]+$'
if [[ $1 =~ $re ]]; then
DOCKERFILES=$(echo "$DOCKERFILES" | shuf -n $1)
Expand Down

0 comments on commit c3d90b1

Please sign in to comment.