waffle: initial Bytecode Alliance-hosted version. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support irreducible control flow by converting it to reducible control flow.
This avoids crashing on very long function bodies.
…mmand. "Every Wasm compiler library contains an incomplete, bug-ridden implementation of half of wasip1", the saying goes. (Or was that about Lisp implementations?) Let's remove the very hacky implementation here: it was only useful to debug waffle during bringup but shouldn't really exist as a user-facing functionality at this point.
This was useful to help debugging at one point, especially differential comparison of before- and after-transform function bodies, but it's an awkward way of doing it (with a new kind of value definition in the IR) and is largely unused at this point, so let's remove it.
|
For the record: once this is reviewed and merged, my plan is to make another release right away, so the "pipeline is flushed" and all published artifacts come from the new official repo. |
sunfishcode
reviewed
Sep 11, 2024
|
Thanks for the review/feedback; updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports the entire commit history of waffle (almost three years of it!) into the bytecodealliance/waffle repository1.
A small amount of the code this includes has already been reviewed in PRs in my initial repo (cfallin/waffle), but most has not. Let's fix that!
Footnotes
technical note: I wanted to keep the full commit history (including a few contributions from others I've gotten in the past). GitHub by default doesn't allow a PR to suggest replacing the
mainbranch with an unrelated commit, though, and rebasing everything on top of Nick's "empty" initial commit created with this repo was proving challenging with nonlinear history. The best methodology I was able to come with was to create a final merge-commit between my repo's head and this empty initial-commit; thus the history has two roots, but GitHub is happy to see the trees are "related". ↩