Implement remaining Windows filesystem functions #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoraaver
force-pushed
the
windows-filesystem
branch
2 times, most recently
from
31d0d65
to
db5d928
Compare
wenyongh
reviewed
Feb 22, 2024
|
@loganek Could you help review this PR? It should be in ready status, the CI failures are due to other issues and we are looking into them. |
loganek
reviewed
Feb 22, 2024
loganek
reviewed
Feb 22, 2024
| @@ -41,6 +41,12 @@ readonly THREAD_INTERNAL_TESTS="${WAMR_DIR}/core/iwasm/libraries/lib-wasi-thread | |||
| readonly THREAD_STRESS_TESTS="${WAMR_DIR}/core/iwasm/libraries/lib-wasi-threads/stress-test/" | |||
| readonly LIB_SOCKET_TESTS="${WAMR_DIR}/core/iwasm/libraries/lib-socket/test/" | |||
|
|
|||
| add_env_key_to_test_config_file() { | |||
| filepath="tests/$2/testsuite/$3.json" | |||
There was a problem hiding this comment.
Instead of modifying test files, could we perhaps extend the WAMR adapter and allow passing env variables through it?
There was a problem hiding this comment.
Good idea 👍 - this is a bit hacky
There was a problem hiding this comment.
Opened a PR, WebAssembly/wasi-testsuite#99.
Now that the filesystem implementation is now complete, the previous test filters on Windows can be removed. Some of the tests only pass when certain environment variables have been set on Windows so an extra step has been added in the wasi test runner script to modify the test config files before the tests begin.
zoraaver
force-pushed
the
windows-filesystem
branch
from
db5d928
to
2636f28
Compare
wenyongh
approved these changes
Feb 28, 2024
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…e#3166) Now that the filesystem implementation is now complete, the previous test filters on Windows can be removed. Some of the tests only pass when certain environment variables have been set on Windows so an extra step has been added in the wasi test runner script to modify the test config files before the tests begin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the filesystem implementation is now complete, the previous test filters on Windows can be removed. Some of the tests only pass when certain environment variables have been set on Windows so an extra step has been added in the wasi test runner script to modify the test config files before the tests begin.