Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine wasm/aot function instance lookup #3865

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Refine wasm/aot function instance lookup #3865

merged 4 commits into from
Oct 18, 2024

Conversation

wenyongh
Copy link
Contributor

Sort the module instance's export functions with the function name,
and use binary search to lookup the wasm function.

@wenyongh wenyongh mentioned this pull request Oct 17, 2024
Merged
lum1n0us
lum1n0us approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

followings include giving name to wasm_exter_t in interp_process_export() and aot_process_export().

xujuntwt95329
xujuntwt95329 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 48eaa22 into bytecodealliance:main Oct 18, 2024
383 checks passed
Zzzabiyaka pushed a commit to Zzzabiyaka/wasm-micro-runtime that referenced this pull request Oct 22, 2024
@wenyongh @Zzzabiyaka
Refine wasm/aot function instance lookup (bytecodealliance#3865)
9f608fd 
Sort the module instance's export functions with the function name,
and use binary search to lookup the wasm/aot function.
@wenyongh wenyongh deleted the dev/refine_lookup_function branch October 24, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamt yamt yamt left review comments

@lum1n0us lum1n0us lum1n0us approved these changes

@xujuntwt95329 xujuntwt95329 xujuntwt95329 approved these changes

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenyongh @yamt @xujuntwt95329 @lum1n0us