[instantiation linking] create and import WASMMemoryInstance for aot #3887

lum1n0us · 2024-10-28T02:35:39Z

based on #3845

- ~99% same with memory_instantiation() in wasm_runtime.c - new apis to create and destroy memory

…tantiation logic in wasm_runtime.c

…reads

core/iwasm/aot/aot_loader.c

core/iwasm/aot/aot_runtime.c

core/iwasm/common/wasm_runtime_common.c

core/iwasm/compilation/aot_emit_aot_file.c

…count

…nd remove unused code

wenyongh

Had better test whether the AOT file compiled by older wamrc work in the new code?

core/iwasm/include/wasm_export.h

core/iwasm/compilation/aot.c

core/iwasm/compilation/aot_emit_aot_file.c

…y structure

lum1n0us · 2024-11-19T11:45:50Z

Had better test whether the AOT file compiled by older wamrc work in the new code?

Agreed. I intend to do that once all four WASMXXXInstance have been implemented. However, given the current progress, it is difficult to ensure compatibility starting from WASMGlobalInstance.

…port memories

wenyongh

LGTM

lum1n0us force-pushed the feat_inst_linking_memory_aot branch 5 times, most recently from 9ef6ec2 to 730cd55 Compare November 1, 2024 13:00

lum1n0us marked this pull request as ready for review November 1, 2024 13:35

lum1n0us requested review from loganek, no1wudi, wenyongh, xujuntwt95329 and yamt as code owners November 1, 2024 13:35

This was referenced Nov 3, 2024

[instantiation linking] Refactor wasm_runtime_instantiate() #3893

Merged

[RFC] Support instantiation linking #3807

Open

Add memory import support #3795

Closed

lum1n0us force-pushed the feat_inst_linking_memory_aot branch from 730cd55 to 15f9ad5 Compare November 4, 2024 06:42

lum1n0us added 9 commits November 4, 2024 07:39

Allow .aot files in raw demo

d1139cc

Allow to emit and load import_memory info

9189eae

create/destroy memory api for aot

14de319

Refactor memory instantiation logic

505dbef

- ~99% same with memory_instantiation() in wasm_runtime.c - new apis to create and destroy memory

Refactor AOT memory handling and improve memory initialization logic

e4fd6ee

fix memory instantiation issues

454d576

Refactor aot_instantiate function parameters for improved clarity

929e4a3

Add wasm_runtime_get_extern_instance function and refactor memory ins…

ac405d3

…tantiation logic in wasm_runtime.c

Implement import inheritance and disinheritance functions for WASI th…

365cee9

…reads

lum1n0us force-pushed the feat_inst_linking_memory_aot branch from 15f9ad5 to 878287d Compare November 4, 2024 07:41

lum1n0us commented Nov 4, 2024

View reviewed changes

core/iwasm/aot/aot_loader.c Show resolved Hide resolved

wenyongh reviewed Nov 18, 2024

View reviewed changes

Fix memory deinstantiation loop to correctly reference import_memory_…

b0cc5ce

…count

lum1n0us force-pushed the feat_inst_linking_memory_aot branch from 878287d to b0cc5ce Compare November 18, 2024 07:34

Refactor aot_lookup_memory function to simplify memory lookup logic a…

4f00332

…nd remove unused code

Add documentation for imports in InstantiationArgs structure

a821adf

wenyongh reviewed Nov 18, 2024

View reviewed changes

Fix memory allocation check and update documentation for import memor…

e4cde59

…y structure

Align memory size and offset calculations to 4-byte boundaries for im…

01ac337

…port memories

wenyongh approved these changes Nov 20, 2024

View reviewed changes

lum1n0us merged commit 9b5058c into bytecodealliance:dev/instantiate_linking Nov 20, 2024
382 of 383 checks passed

lum1n0us deleted the feat_inst_linking_memory_aot branch November 20, 2024 03:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[instantiation linking] create and import WASMMemoryInstance for aot #3887

[instantiation linking] create and import WASMMemoryInstance for aot #3887

lum1n0us commented Oct 28, 2024

wenyongh left a comment

lum1n0us commented Nov 19, 2024

wenyongh left a comment

[instantiation linking] create and import WASMMemoryInstance for aot #3887

[instantiation linking] create and import WASMMemoryInstance for aot #3887

Conversation

lum1n0us commented Oct 28, 2024

wenyongh left a comment

Choose a reason for hiding this comment

lum1n0us commented Nov 19, 2024

wenyongh left a comment

Choose a reason for hiding this comment