Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize memory initialization handling in AOT loader #3983

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

no1wudi
Copy link
Collaborator

@no1wudi no1wudi commented Dec 24, 2024

Save memory if the file buffer is always exist before exit.

@wenyongh
Copy link
Contributor

This is to make the memory init data available and wasm/aot module can be used again when module->is_binary_freeable is true and the wasm/aot binary is freed after loading?

@no1wudi
Copy link
Collaborator Author

no1wudi commented Dec 25, 2024

Yes, the AOT binary should be available before runtime exit

@no1wudi no1wudi force-pushed the main branch 2 times, most recently from adb7ec2 to e55ddf4 Compare December 25, 2024 07:23
Save memory if the file buffer is always exist before exit.

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@TianlongLiang TianlongLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lum1n0us lum1n0us merged commit 38cf274 into bytecodealliance:main Dec 26, 2024
383 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants