Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heap_base and data_end have to be local globals #3996

Merged
merged 1 commit into from
Jan 3, 2025
Merged

heap_base and data_end have to be local globals #3996

merged 1 commit into from
Jan 3, 2025

Conversation

lum1n0us
Copy link
Collaborator

No description provided.

@lum1n0us lum1n0us force-pushed the fix/pre_defined_local_global branch 2 times, most recently from 8c10765 to 744edcf Compare December 31, 2024 05:45
TianlongLiang
TianlongLiang approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@TianlongLiang TianlongLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wenyongh
wenyongh reviewed Jan 3, 2025
View reviewed changes
core/iwasm/interpreter/wasm_loader.c Outdated Show resolved Hide resolved
core/iwasm/interpreter/wasm_loader.c Outdated Show resolved Hide resolved
@lum1n0us lum1n0us force-pushed the fix/pre_defined_local_global branch from 744edcf to 98404b7 Compare January 3, 2025 05:06
wenyongh
wenyongh approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lum1n0us lum1n0us merged commit 099056b into bytecodealliance:main Jan 3, 2025
383 checks passed
@lum1n0us lum1n0us deleted the fix/pre_defined_local_global branch January 3, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TianlongLiang TianlongLiang TianlongLiang approved these changes

@wenyongh wenyongh wenyongh approved these changes

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lum1n0us @wenyongh @TianlongLiang