C#: Remove the emscripten compiler and rely on wasi-sdk #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM; looks like we'll need to remove the |
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
jsturtevant
changed the title
|
I've seen the latest CI failure before; it's an intermittent failure. Might need to re-run the job. |
dicej
approved these changes
Jun 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that dotnet/runtimelab#2592 has merged and released we no longer need emscripten which reduces requirements for installing.
Also update to use correct wasi-sdk url for windows: #967 (comment)
Used @dicej patch for the
csprojupdate: #967 (comment)