Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update wit-bindgen to 0.30 #211

Merged
merged 27 commits into from
Aug 15, 2024

Conversation

rvolosatovs
Copy link
Member

No description provided.

alexcrichton and others added 17 commits July 8, 2024 14:32
Looks like the old CentOS mirrors are being decommissioned.
* Revert "temporarily remove C# `variants` runtime test (#963)"

This reverts commit 3ca7739.

As of dotnet/runtimelab#2609, the "return pointer not
aligned" issue which forced us to remove the C# `variants` runtime test case
_should_ be resolved. 🤞

Signed-off-by: Joel Dice <joel.dice@fermyon.com>

* update C# variants test to match latest code generator

Signed-off-by: Joel Dice <joel.dice@fermyon.com>

---------

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
* Relicense this repository

This commit relicenses this repository from

    Apache-2.0 WITH LLVM-exception

to

    Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT

in accordance with #987. All contributors have signed off in #987 and
the license metadata and such here match the `wasi-rs` repository in the
bytecodealliance organization as well.

Thank you again everyone for your help here!

Closes #987

* Adjust some CI scripts

* Fix cabi_realloc script

* Fix publish script

* Update license blurb in readme
This commit fixes the `--with` option in the Rust generate from changes
in #972. Notably the fixes here are:

* The `--with` option is no longer required.
* Multiple `--with` options are now accepted again.
* A new `--generate-all` option was added.
* The `generate_all` macro option was documented.
* Error messages on the CLI and the macro now mention all the variants
  of how to fix the error.

Closes #995
This is to avoid the need to add binary .o files (which are difficult to audit
from a security perspective) to the .NET runtime repository.  I will open
related PRs on the `wasm-tools` and `wasm-component-ld` repos to enable the
latter to accept WIT files at link (and componentization) time.

Note that I've taken this opportunity to remove the cabi_realloc C file from the
output, since we can rely on `wasi-libc` providing an implementation.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
* Update wasm-tools crates

* Remove usage of multi-return

* Fix C tests

* Mostly update Go tests
[automatically-tag-and-release-this-commit]

Co-authored-by: Auto Release Process <auto-release-process@users.noreply.github.com>
Signed-off-by: Lachlan Heywood <lachieh@users.noreply.github.com>
…1009)

Signed-off-by: Lachlan Heywood <lachieh@users.noreply.github.com>
* Update to wasm-tools 215

Brings in a breaking change which is hoped to not affect anyone around
how multi-package WITs are handled.

* Fix C test

* Fix main test build

* Remove patch  entries
Originally, I made these `internal` rather than `public` since they aren't meant
to be used in application code.  However, that prevents an important use case:
splitting the bindings across assemblies.

In particular, when targetting a world that includes exports, it's useful to put
the generated types and imports in a reusable library, but we can't put the
exports in that library since the application code should be providing the entry
points.  This is analogous to how a CLI library might provide utilities for
e.g. parsing command line options, but still leave it to the application to
provide a `static int Main` function.

In the case of a world that includes one or more exports, we'll want to put the
generated code for those exports in the application assembly and put everything
else in the library.  However, the export code may need to be able to marshal
raw resource handles into the appropriate object wrapper for that resource type,
and that requires access to the `THandle` struct and corresponding constructor
for that class.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Mirrors the `wasm-tools` CLI
[automatically-tag-and-release-this-commit]

Co-authored-by: Auto Release Process <auto-release-process@users.noreply.github.com>
@rvolosatovs rvolosatovs marked this pull request as ready for review August 5, 2024 07:59
@rvolosatovs rvolosatovs enabled auto-merge August 5, 2024 07:59
@rvolosatovs rvolosatovs marked this pull request as draft August 5, 2024 08:36
auto-merge was automatically disabled August 5, 2024 08:36

Pull request was converted to draft

alexcrichton and others added 7 commits August 5, 2024 22:03
This also locks the ILC dependencies to a specific version to avoid future
surprises.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This code is no longer needed now that the .NET runtime uses WIT files to
represent the component type instead.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This is not needed for the wasi_snapshot_preview1 adapter in Wasmtime
and is causing issues with LLVM 19, so add an option to turn it off
which will be enabled in Wasmtime.
This allows them to be called from other assemblies.

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
[automatically-tag-and-release-this-commit]

Co-authored-by: Auto Release Process <auto-release-process@users.noreply.github.com>
@rvolosatovs rvolosatovs marked this pull request as ready for review August 14, 2024 18:17
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs marked this pull request as draft August 14, 2024 19:05
@rvolosatovs rvolosatovs changed the title build: update dependencies feat: update wit-bindgen Aug 14, 2024
@rvolosatovs rvolosatovs marked this pull request as ready for review August 15, 2024 10:10
@rvolosatovs rvolosatovs changed the title feat: update wit-bindgen feat: update wit-bindgen Aug 15, 2024
@rvolosatovs rvolosatovs changed the title feat: update wit-bindgen feat: update wit-bindgen to 0.30 Aug 15, 2024
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs enabled auto-merge August 15, 2024 10:31
@rvolosatovs rvolosatovs added this pull request to the merge queue Aug 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 15, 2024
@rvolosatovs rvolosatovs merged commit 4723db6 into bytecodealliance:main Aug 15, 2024
25 checks passed
@rvolosatovs rvolosatovs deleted the build/update branch August 15, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants