Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: add button to download hidden papers metadata #70

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

heruka-urgyen
Copy link
Collaborator

Based on this request

This PR adds a clickable label "download selected" in the report header visible when all papers are shown. Clicking on it prompts to save a json file with the hidden papers metadata.

My main consideration for UX / UI here was simplicity of implementation. Open for further discussion.

download-button

@heruka-urgyen heruka-urgyen self-assigned this Oct 30, 2021
@bzz
Copy link
Owner

bzz commented Jan 19, 2022

Somehow I completely missed this 😱 🤦

Having this JSON allows for subsequent filtering out papers marked as not relevant.

One thing I could not immediately understand is that if it generates the base64 encoded JSON data lazy on click, or in advance, while displaying the component 🤔

@heruka-urgyen
Copy link
Collaborator Author

Hi @bzz. Thanks for getting back to this.

if it generates the base64 encoded JSON data lazy on click, or in advance

In fact, you pointed to a bug. This was fixed so the generated json represents selected papers when download is clicked. I chose to rewrite the history, be aware when pulling.

Copy link
Owner

@bzz bzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you.

@bzz
Copy link
Owner

bzz commented Sep 26, 2022

I will get back to #47 then and see what's missing for building a self-contained binary \w the pre-built frontend served from filesystem under /static URL.

@heruka-urgyen
Copy link
Collaborator Author

@bzz fantastic. Thank you. Merging

@heruka-urgyen heruka-urgyen merged commit e1dca62 into master Sep 27, 2022
@heruka-urgyen heruka-urgyen deleted the fe-download branch September 27, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants