improve parser and server reload performance by indexing

caalberts · Oct 21, 2018 · dd3ebb4 · dd3ebb4
1 parent 8ab1b5f
commit dd3ebb4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/http/server.go b/http/server.go
@@ -71,8 +71,8 @@ func (rtr *router) updateSchema(schemas []types.Schema) {
 	rtr.Lock()
 	defer rtr.Unlock()
 	router := httprouter.New()
-	for _, schema := range schemas {
-		router.Handle(schema.Method, schema.Path, handlerFunc(schema))
+	for i := 0; i < len(schemas); i++ {
+		router.Handle(schemas[i].Method, schemas[i].Path, handlerFunc(schemas[i]))
 	}
 	rtr.Handler = router
 }

diff --git a/json/parser.go b/json/parser.go
@@ -48,16 +48,16 @@ func (p *Parser) Watch(input chan io.Reader) {
 func createSchema(stubs []stub) ([]types.Schema, error) {
 	schemas := make([]types.Schema, len(stubs))
 
-	for i, stub := range stubs {
-		if f := missingFields(stub); len(f) > 0 {
+	for i := 0; i < len(stubs); i++ {
+		if f := missingFields(stubs[i]); len(f) > 0 {
 			err := fmt.Errorf("missing required fields: %s", strings.Join(f, ", "))
 			return []types.Schema{}, err
 		}
 		schemas[i] = types.Schema{
-			Method:   *stub.Method,
-			Path:     *stub.Path,
-			Status:   *stub.Status,
-			Response: formatResponse(stub.Response),
+			Method:   *stubs[i].Method,
+			Path:     *stubs[i].Path,
+			Status:   *stubs[i].Status,
+			Response: formatResponse(stubs[i].Response),
 		}
 	}