fix: disable HPA downscaling by default #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroapero
requested review from
Fovty,
jonathan-mayer and
JTaeuber
as code owners
The default downtime minimum replicas is 0; and the minReplicas field can't be 0 in HorizontalPodAutscaler. This fixes the default installation from crashing when there are HorizontalPodAutoscalers with unspecified downscaler/downtime-replicas annotation.
|
Note: an HPA does not scale Deployments with minReplicas=0 (so even with HPAs; all Deployments will still be downscaled by default). Rebased to include the cobertura workflow fix. |
JTaeuber
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The default downtime minimum replicas is 0; and the minReplicas field can't be 0 in HorizontalPodAutscaler.
Hence the default installation crashes when there are HorizontalPodAutoscalers with unspecified downscaler/downtime-replicas annotation.
Changes
Disable the downscaling of HorizontalPodAutoscalers by default (it cannot work by default as it requires manual annotations to be functional).
Tests done