add a nil case to ValueFromPtr

cadence-workflow · Nov 11, 2024 · e209ff6 · e209ff6
1 parent d2b87f4
commit e209ff6
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/internal/common/convert_test.go b/internal/common/convert_test.go
@@ -64,6 +64,7 @@ func TestValueFromPtr(t *testing.T) {
 	assert.Equal(t, 1.1, ValueFromPtr(PtrOf(1.1)))
 	assert.Equal(t, true, ValueFromPtr(PtrOf(true)))
 	assert.Equal(t, []string{"a"}, ValueFromPtr(PtrOf([]string{"a"})))
+	assert.Equal(t, "" /* default value */, ValueFromPtr((*string)(nil)))
 }
 
 func TestZero(t *testing.T) {