Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update idl and add wrapper implementaton for async start/signalwithstart APIs #1321

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented Mar 18, 2024

What changed?
Updating client to expose newly added async APIs:

  • SignalWithStartWorkflowExecutionAsync
  • StartWorkflowExecutionAsync

Steps followed to update idls

  • Update submodule
cd idls
git checkout 34b4519b270945fbb38f413137dfb50b5fc20af7
  • Update idl go dependency
go get github.com/uber/cadence-idl@34b4519b270945fbb38f413137dfb50b5fc20af7
  • Build and fix failures
make build
make unit_test
make integ_test_sticky_off

How did you test it?
Added unit tests for new methods

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

❗ No coverage uploaded for pull request base (master@00ff688). Click here to learn what that means.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
internal/common/auth/service_wrapper.go 93.54% <100.00%> (ø)
internal/common/isolationgroup/service_wrapper.go 91.47% <100.00%> (ø)
internal/common/metrics/service_wrapper.go 66.10% <100.00%> (ø)
internal/internal_utils.go 72.83% <ø> (ø)
internal/oauth_authorization.go 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ff688...08cde0b. Read the comment docs.

@taylanisikdemir taylanisikdemir changed the title Update idl and add wrapper implementaton for async start/signalwithstart APIs [WIP] Update idl and add wrapper implementaton for async start/signalwithstart APIs Mar 18, 2024
@taylanisikdemir taylanisikdemir changed the title [WIP] Update idl and add wrapper implementaton for async start/signalwithstart APIs Update idl and add wrapper implementaton for async start/signalwithstart APIs Mar 18, 2024
Copy link
Member

@shijiesheng shijiesheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylanisikdemir taylanisikdemir merged commit ba7fa67 into cadence-workflow:master Mar 19, 2024
12 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/start_signalwithstart_async_apis branch March 19, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants