Don't treat missing PartitionConfig data as an error #6576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemort
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
We intentionally set the isolation group to "" when we leak tasks, which causes forwarded tasks to report an error resolving the isolation group. Additionally update the matching simulation to use the isolation group based load balancer and provide a default for the QpsTrackerInterval. 0s results in a panic on service startup. Additionally specify an Identity on requests in the matching simulation so that poller history is tracked.
taylanisikdemir
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We intentionally set the isolation group to "" when we leak tasks, which causes forwarded tasks to report an error resolving the isolation group. Don't return an error in this case, or if the task happens not to have a PartitionConfig.
Additionally update the matching simulation to use the isolation group based load balancer and provide a default for the QpsTrackerInterval. 0s results in a panic on service startup.
Additionally specify an Identity on requests in the matching simulation so that poller history is tracked.
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes