Add test and PermissionNotFound exception

src/Concerns/HasPermissions.php

@@ -5,6 +5,7 @@
 use Caffeinated\Shinobi\Facades\Shinobi;
 use Caffeinated\Shinobi\Contracts\Permission;
 use Illuminate\Database\Eloquent\Relations\BelongsToMany;
+use Caffeinated\Shinobi\Exceptions\PermissionNotFoundException;
 
 trait HasPermissions
 {
@@ -39,24 +40,17 @@ public function hasPermissionTo($permission): bool
 
         // Fetch permission if we pass through a string
         if (is_string($permission)) {
-            try {
-                $model = $this->getPermissionModel();
-
-                if(method_exists($model, 'firstOrFail'))
-                    $permission = $model->where('slug', $permission)->firstOrFail();
-                else //If its cached
-                    $permission = $model->where('slug', $permission)->first();
-
-            } catch (\Exception $e) {
+            $permission = $this->getPermissionModel()->where('slug', $permission)->first();
 
+            if (! $permission) {
+                throw new PermissionNotFoundException;
             }
         }
 
         // Check role permissions
         if (method_exists($this, 'hasPermissionThroughRole') and $this->hasPermissionThroughRole($permission)) {
             return true;
         }
-
 
         // Check user permission
         if ($this->hasPermission($permission)) {

src/Exceptions/PermissionNotFoundException.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace Caffeinated\Shinobi\Exceptions;
+
+use Exception;
+
+class PermissionNotFoundException extends Exception
+{
+    // 
+}

tests/PermissionTest.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace Caffeinated\Shinobi\Tests;
+
+use Caffeinated\Shinobi\Tests\User;
+use Caffeinated\Shinobi\Exceptions\PermissionNotFoundException;
+
+class PermissionTest extends TestCase
+{
+    /** @test */
+    public function a_non_existant_permission_should_throw_an_exception()
+    {
+        $this->expectException(PermissionNotFoundException::class);
+
+        $user = factory(User::class)->create();
+
+        $user->hasPermissionTo('i.dont.exist');
+    }
+}