Skip to content

Commit

Permalink
fix: Remove extra logging on error (#145)
Browse files Browse the repository at this point in the history
* fix: Remove extra logging on error

The log.Fatal() can be removed because for .Execute() to reuturn an
error means that that error is recoverable and the default CLI error msg
has been thrown, so this fatal log is redundant.

Signed-off-by: AlexNg <contact@ngjx.org>

* chore: bump 0.3.2 -> 0.3.3

Signed-off-by: AlexNg <contact@ngjx.org>

---------

Signed-off-by: AlexNg <contact@ngjx.org>
  • Loading branch information
caffeine-addictt authored Sep 30, 2024
1 parent 8a2929d commit b330616
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 13 deletions.
2 changes: 1 addition & 1 deletion cmd/global/version.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package global

// The current app version
const Version = "0.3.2"
const Version = "0.3.3"
6 changes: 1 addition & 5 deletions cmd/root.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package cmd

import (
"log"

"github.com/caffeine-addictt/waku/cmd/commands"
"github.com/caffeine-addictt/waku/cmd/options"
"github.com/caffeine-addictt/waku/cmd/utils"
Expand Down Expand Up @@ -32,7 +30,5 @@ func init() {

// The main entry point for the command line tool
func Execute() {
if err := RootCmd.Execute(); err != nil {
log.Fatal(err)
}
_ = RootCmd.Execute()
}
4 changes: 2 additions & 2 deletions www/docs/configuration/introduction.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ for better editor support.
https://waku.ngjx.org/static/schema.json
```

Or you can pin a specific version like `v0.3.2`:
Or you can pin a specific version like `v0.3.3`:

```text
https://raw.githubusercontent.com/caffeine-addictt/waku/v0.3.2/www/docs/static/schema.json
https://raw.githubusercontent.com/caffeine-addictt/waku/v0.3.3/www/docs/static/schema.json
```

Simply add the `$schema` property to your `template.json` file:
Expand Down
10 changes: 5 additions & 5 deletions www/docs/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,17 +108,17 @@ All artifacts are checksummed, and the checksum file is signed with [cosign][].
and `checksums.txt.sig` files from the [releases][] page.

```sh
curl -O 'https://github.com/caffeine-addictt/waku/releases/download/v0.3.2/checksums.txt'
curl -O 'https://github.com/caffeine-addictt/waku/releases/download/v0.3.3/checksums.txt'
```

1. Verify checksums signature:

```bash
cosign verify-blob \
--certificate-identity 'https://github.com/caffeine-addictt/waku/.github/workflows/release.yml@refs/tags/v0.3.2' \
--certificate-identity 'https://github.com/caffeine-addictt/waku/.github/workflows/release.yml@refs/tags/v0.3.3' \
--certificate-oidc-issuer 'https://token.actions.githubusercontent.com' \
--cert 'https://github.com/caffeine-addictt/waku/releases/download/v0.3.2/checksums.txt.pem' \
--signature 'https://github.com/caffeine-addictt/waku/releases/download/v0.3.2/checksums.txt.sig' \
--cert 'https://github.com/caffeine-addictt/waku/releases/download/v0.3.3/checksums.txt.pem' \
--signature 'https://github.com/caffeine-addictt/waku/releases/download/v0.3.3/checksums.txt.sig' \
./checksums.txt
```

Expand All @@ -136,7 +136,7 @@ Verify the signature:

```sh
cosign verify \
--certificate-identity 'https://github.com/caffeine-addictt/waku/.github/workflows/release.yml@refs/tags/v0.3.2' \
--certificate-identity 'https://github.com/caffeine-addictt/waku/.github/workflows/release.yml@refs/tags/v0.3.3' \
--certificate-oidc-issuer 'https://token.actions.githubusercontent.com' \
caffeinec/waku
```
Expand Down

0 comments on commit b330616

Please sign in to comment.