-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document changes in DotNetTool Module starting with Cake 1.1.0 #1739
Comments
Hi @augustoproiete, I'd like to help out. What are the changes you would like done exactly? |
Hi @TomerPacific thanks for your interest in this one. The intent is to add the recommendation above to this page here: https://cakebuild.net/extensions/cake-dotnettool-module/ |
@augustoproiete, I've taken a look inside the project to see how I can add what you have written and am coming up short. I've been looking at the 7zip extension as a go to guide to follow, but have yet to find out how the Aliases text has been added there. From a brief search I found out the config.wyam file, but I am not sure how it all fits in together. I would appreciate it if you could declutter some of this. |
@TomerPacific Thanks for looking deeper into this one. We discussed this a while ago, and I believe the easiest path forward is to add a hard-coded alert in the page for now (e.g. As part of this change, we should also rollback the last changes that were made to -AnalyzedPackageVersion: 1.1.0
+AnalyzedPackageVersion: 1.0.1
AnalyzedPackageIsPrerelease: false
-AnalyzedPackagePublishDate: 2021-03-06T06:37:35.9600000Z
+AnalyzedPackagePublishDate: 2021-02-22T20:53:19.0970000Z The description you see at the top is coming from the |
thanks for the lengthy explanation, @augustoproiete. So, if I understand correctly, since the documentation field in the yml file does not support markup, adding the required text inside of an alert will take place inside the _ExtensionsPage.cshtml? |
@TomerPacific Yes , except that to make it a little cleaner, lets store the alert text on a separate file e.g. |
@augustoproiete, I have started working on this and would like to get your input on what I am doing.
|
@TomerPacific The description of the extension that you see on the individual page of each extension is rendered in _ExtensionsLayout.cshtml. This is where you would add the condition to render the partial view with the alert.
I'm not sure what kind of syntax you're referring to, but all |
@augustoproiete, I just wanted to update that I am having some issues setting up a local environment so I can check things locally. I have opened a discussion to try and overcome these problems. I'll let you know if I get stuck. |
@augustoproiete, how's it looking so far? |
Looks like it's almost there 🎉 . I'd only suggest bringing it below the title to make it more clear that the warning is about the Cake.DotNetTool.Module itself and not a general warning of the website /cc @pascalberger Any thoughts? |
Recommendation
If you use
Cake.DotNetTool.Module
already on your builds, you should either:(1) Upgrade Cake to version 1.1.0, and remove the
Cake.DotNetTool.Module
from your build script (as it's no longer needed)or
Cake.DotNetTool.Module
to a version compatible with the Cake version that you use.Cake.DotNetTool.Module
version 1.0.1 is the last version compatible with Cake 1.0.0. Starting with this release,Cake.DotNetTool.Module
will always be released together with Cake and will only be compatible with the current release.https://cakebuild.net/extensions/cake-dotnettool-module/
Relates to:
The text was updated successfully, but these errors were encountered: