Dotnetmodule Documentation Changes #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
augustoproiete
requested changes
Oct 10, 2021
|
@augustoproiete - I have updated the code with your suggestions and also the screenshot of the site. I added |
|
@TomerPacific LGTM. I moved the alert down from the header section to the content section just so that we can have a little gap/margin between the title and the alert box:
|
gep13
reviewed
Oct 11, 2021
pascalberger
requested changes
Oct 11, 2021
pascalberger
requested changes
Oct 11, 2021
pascalberger
approved these changes
Oct 11, 2021
Co-authored-by: C. Augusto Proiete <augusto@proiete.com> Co-authored-by: Gary Ewan Park <gep13@gep13.co.uk> Co-authored-by: Pascal Berger <pascal.berger@gmail.com>
TomerPacific
deleted the
feature/dotnetmodule-documentation-changes-1739
branch
|
@augustoproiete, @pascalberger, just wanted to say thanks again for all your assistance and patience throughout this. |
|
@TomerPacific thanks for your contribution 👍 |
|
@TomerPacific You're welcome! Thanks for your contribution to the Cake project. Your changes are online: https://cakebuild.net/extensions/cake-dotnettool-module/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1739
Following the suggestion in the issue, a description was added to the DotNetModule extension.
The version of the extension was also reverted back to the previous version.