fix: material svg icon size fix #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case of material icon's default width calculation doesn't work and mostly render really tiny icon. But they do have width props which can be used here to calculate correct icon size.
|
A few examples I tried seemed to have worked OK, but it has been a while. Can you share a (or a few) examples that don't currently work? |
|
All the material icons have the same props, |
|
Hi, i was wondering if anything outstanding fpr this? If not is ot possible to review and merge? |
|
Hi, I am really sorry, I forgot about this. I investigated it a bit today and I believe this is due to a bug with the aspect ratio calculation, see the linked commit. I think this is the right way to solve it and it seems to work correctly for me, please let me know if you still have such issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case of material icon's default width calculation doesn't work and mostly render really tiny icon. But they do have width props which can be used here to calculate correct icon size.