Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an artifact as destination option for using in subsequent jobs #72

Merged
merged 19 commits into from
Feb 18, 2024
Merged

Add an artifact as destination option for using in subsequent jobs #72

merged 19 commits into from
Feb 18, 2024

Conversation

michaelrommel
Copy link
Contributor

This PR adds the functionality to add in addition to a commit or as alternative an artifact where the generated svg and yaml files are stored.

The workflow outputs the artifact-id as well as let the user define the name of the artifacts zip file.

@michaelrommel
Copy link
Contributor Author

michaelrommel commented Feb 14, 2024

I have to figure out how to squash all those commits into one before opening a PR. Sorry about that...

Oh, and all that fromJSON stuff is just because my images/ folder has more yaml files in it, so I only wanted the generated ones from keymap-drawer in the artifact, not the existing ones from the repo. So I thought it makes sense, to build an array with all generated .svg|.yaml files and give that to upload-artifact. But I did not test it with multiple keyboards, I currently have only one... 😅

@caksoylar
Copy link
Owner

Don't worry about the commits, I can squash while merging, unless there is multiple functionality that would be better off in separate commits. Thanks for the PR, I'll review this later today.

.github/workflows/draw-zmk.yml Outdated Show resolved Hide resolved
.github/workflows/draw-zmk.yml Outdated Show resolved Hide resolved
.github/workflows/draw-zmk.yml Outdated Show resolved Hide resolved
.github/workflows/draw-zmk.yml Show resolved Hide resolved
.github/workflows/draw-zmk.yml Outdated Show resolved Hide resolved
@caksoylar
Copy link
Owner

Tested at https://github.com/caksoylar/zmk-config/actions/runs/7945165830 as well, thanks!

@caksoylar caksoylar merged commit a59653b into caksoylar:main Feb 18, 2024
1 check passed
@michaelrommel
Copy link
Contributor Author

Thank you, Cem, for letting me work with you on this! I have now deleted my fork and referenced your official workflow again!
Have a good weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants