Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remaining BastardKB boards #76

Merged
merged 1 commit into from
Mar 16, 2024
Merged

add remaining BastardKB boards #76

merged 1 commit into from
Mar 16, 2024

Conversation

burkfers
Copy link
Contributor

@burkfers burkfers commented Mar 15, 2024

This change adds pretty staggered layouts for the remaining BastardKB boards: The entire Charybdis and Dactyl families, including

  • Charybdis Nano (3x5)
  • Charybdis Mini (3x6)
  • Charybdis (4x6)
  • Skeletyl
  • TBKMini
  • Scylla

The jsons have been hand-formatted to be as human-readable as possible.

Examples (both yaml and resulting image) can be viewed here: https://github.com/finrod09/bastardkb.github.io/tree/keymap-images/assets/pics/layouts

pending checks that I've used the correct stock LAYOUT macros

@burkfers
Copy link
Contributor Author

burkfers commented Mar 16, 2024

I've changed the LAYOUT macros to match qmk info.json. Quentin has given his approval on the visuals. Ready to go on my end!

I'll be happy about any feedback you might have.

@burkfers burkfers marked this pull request as ready for review March 16, 2024 17:34
@caksoylar
Copy link
Owner

Thanks, I appreciate you contributing! It looks like you covered all the bases w.r.t. naming and layouts. Creator approval is certainly a higher bar than I set so far and it's good to have :)

@caksoylar caksoylar merged commit 11e9769 into caksoylar:main Mar 16, 2024
1 check passed
@burkfers burkfers deleted the bkb branch March 16, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants