Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker image for the CLI #88

Closed
wants to merge 5 commits into from
Closed

Add Docker image for the CLI #88

wants to merge 5 commits into from

Conversation

hnaderi
Copy link

@hnaderi hnaderi commented Apr 10, 2024

Hi, Thanks for this great tool!
This PR adds a docker image that is automatically published to the GitHub container registry for tags and pushes on main.
Having a docker image for the CLI would make it easier to use the CLI in the CI/CD and on other platforms.

@hnaderi hnaderi force-pushed the main branch 2 times, most recently from 4a1dcb4 to bd7c63b Compare April 10, 2024 11:17
@caksoylar
Copy link
Owner

Hi, thanks for the nice words and the PR!

Can I ask why you use the Docker container, for example over the pip installation on your OS? I try to keep the installation simple and not very intrusive to your system (e.g. if you use pipx), and I feel like a Docker image might be overkill for this application. But I am open to changing my mind and I'd be interested to learn why others might prefer using a container.

@hnaderi
Copy link
Author

hnaderi commented Apr 13, 2024

The main use case would be on CI pipelines, where the containers are often used as an environment (it was my use case in the first place).
Using pipx is also really easy but requires extra packaging on immutable OSes like NixOS and Guix.

However, given the fact that it might be a niche use case and not the common use case I also think it might be overkill and I'm completely fine if you think it should be out of the scope of this project.

@caksoylar
Copy link
Owner

caksoylar commented Apr 14, 2024

Thanks for the response, I admittedly am not familiar with Nix/Guix and limitations of pip installing in them. I think I'd rather not maintain it and I appreciate you understanding.

If you let me know a stable url I can point to (like your fork's main) I will add a pointer to the Dockerfile in the community section of the README, in case this is useful to anyone else.

@hnaderi
Copy link
Author

hnaderi commented Apr 14, 2024

Sure, I changed the README in my fork to have the address of the container image in my container registry on GitHub.
I'll close this one, thanks for the time @caksoylar 😊

@hnaderi hnaderi closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants