Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added zod schema #17694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

realAbhi-web
Copy link

@realAbhi-web realAbhi-web commented Nov 17, 2024

What does this PR do?

Added Zod Schema to validate and parse app metadata stored in config.json to ensure consistency and better error handling.

-GitHub issue number - #14808

  • Fixes CAL-3584

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).

  • yes

  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.

  • no

  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

  • yes

How should this be tested?

The schema should validate the config.json and pass without errors if the metadata is correct.

  • Are there environment variables that should be set?
    no

Checklist

  • I haven't read the contributing guide
    yes

  • My code doesn't follow the style guidelines of this project
    no

  • I haven't commented my code, particularly in hard-to-understand areas
    yes

  • I haven't checked if my changes generate no new warnings
    yes

Copy link

vercel bot commented Nov 17, 2024

@realAbhi-web is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Nov 17, 2024
@graphite-app graphite-app bot requested review from a team November 17, 2024 06:29
@CLAassistant
Copy link

CLAassistant commented Nov 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Nov 17, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Zod Schema feat. done". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added the ✨ feature New feature or request label Nov 17, 2024
Copy link

graphite-app bot commented Nov 17, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (11/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (11/17/24)

1 label was added to this PR based on Keith Williams's automation.

@Praashh Praashh changed the title Zod Schema feat. done feat: Added zod schema Nov 17, 2024
@keithwillcode
Copy link
Contributor

@hariombalhara Can you please take a look at this one?

@hariombalhara
Copy link
Member

@realAbhi-web Thanks for the PR 🙏

Could you take a look at this comment and see if it would improve things and is doable or not?

#14997 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync ✨ feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants