Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clients not receiving appointment details by email #17698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vishwamartur
Copy link

Related to #17662

Add functionality to send appointment confirmation emails to clients after booking creation.

  • packages/emails/email-manager.ts

    • Add sendAppointmentConfirmationEmail function to send appointment confirmation emails to clients.
    • Import necessary modules and templates for the new function.
  • apps/api/v1/pages/api/bookings/_post.ts

    • Import sendAppointmentConfirmationEmail function.
    • Call sendAppointmentConfirmationEmail function after a booking is created.
  • apps/api/v2/src/modules/email/email.service.ts

    • Add sendAppointmentConfirmationEmail method to send appointment confirmation emails to clients.
    • Import necessary modules and templates for the new method.
  • apps/api/v1/test/lib/bookings/_post.test.ts

    • Add test cases to verify that sendAppointmentConfirmationEmail function is called after a booking is created.

Related to calcom#17662

Add functionality to send appointment confirmation emails to clients after booking creation.

* **packages/emails/email-manager.ts**
  - Add `sendAppointmentConfirmationEmail` function to send appointment confirmation emails to clients.
  - Import necessary modules and templates for the new function.

* **apps/api/v1/pages/api/bookings/_post.ts**
  - Import `sendAppointmentConfirmationEmail` function.
  - Call `sendAppointmentConfirmationEmail` function after a booking is created.

* **apps/api/v2/src/modules/email/email.service.ts**
  - Add `sendAppointmentConfirmationEmail` method to send appointment confirmation emails to clients.
  - Import necessary modules and templates for the new method.

* **apps/api/v1/test/lib/bookings/_post.test.ts**
  - Add test cases to verify that `sendAppointmentConfirmationEmail` function is called after a booking is created.
Copy link

vercel bot commented Nov 17, 2024

@vishwamartur is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team November 17, 2024 17:09
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Nov 17, 2024
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Fix clients not receiving appointment details by email". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added the emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email label Nov 17, 2024
Copy link

graphite-app bot commented Nov 17, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (11/17/24)

1 label was added to this PR based on Keith Williams's automation.

@Praashh Praashh changed the title Fix clients not receiving appointment details by email fix: clients not receiving appointment details by email Nov 17, 2024
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @vishwamartur can you add a loom for reproduce this issue locally?

@vishwamartur
Copy link
Author

@Praashh

hey @vishwamartur can you add a loom for reproduce this issue locally?

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants