feat: add reassign reason + rename insights #17720
Open
+21
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
insights
sean-brydon
commented
Nov 18, 2024
There was a problem hiding this comment.
Moved to /bookings > /routing
sean-brydon
commented
Nov 18, 2024
| @@ -238,6 +238,7 @@ class RoutingEventsInsights { | |||
| uid: true, | |||
| status: true, | |||
| createdAt: true, | |||
| reassignReason: true, | |||
There was a problem hiding this comment.
Add reassign reason to table
sean-brydon
commented
Nov 18, 2024
Comment on lines
+624
to
+625
| "Reassigned By": response.routedToBooking?.reassignBy?.name || "", | ||
| "Reassigned Reason": response.routedToBooking?.reassignReason || "", |
There was a problem hiding this comment.
Provide Reassign reason and who reassigned in routing form export
sean-brydon
commented
Nov 18, 2024
| @@ -89,14 +89,14 @@ const navigation: NavigationItemType[] = [ | |||
| isCurrent: ({ pathname: path, item }) => path?.startsWith(item.href) ?? false, | |||
| child: [ | |||
There was a problem hiding this comment.
Rename tabs - see PR description for reasoning.
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/18/24)1 reviewer was added to this PR based on Keith Williams's automation. |
joeauyeung
requested changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Here we add reassign reason to response csv export and also to data-table.
We also rename tabs to be summary,booking. Booking (previously routing) will provide a more detailed break down specific to bookings and routing form responses. Where as summary is/will become a more top level breakdown of the organization.
How should this be tested?
Checklist