Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: space inserted after function interpolation (fixes #1141 #1368) #1374

Merged

Conversation

agriffis
Copy link
Contributor

Motivation

See #1141 and #1368

Summary

lastTemplateElementLocation attempted to track end of previous template element, but it failed to update for expressions. On review, it seems that lastTemplateElementLocation isn't necessary at all, since ex.loc.start contains the necessary location.

It is possible that I misunderstood the motivation for lastTemplateElementLocation but it hasn't been clear to me yet.

Test plan

There was already a failing test case for this added in #1151. This PR fixes that snapshot.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

🦋 Changeset detected

Latest commit: 2d327ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@linaria/tags Patch
@linaria/testkit Patch
@linaria/atomic Patch
@linaria/babel-preset Patch
@linaria/core Patch
@linaria/griffel Patch
@linaria/react Patch
linaria-website Patch
@linaria/cli Patch
@linaria/esbuild Patch
linaria Patch
@linaria/rollup Patch
@linaria/stylelint Patch
@linaria/vite Patch
@linaria/webpack4-loader Patch
@linaria/webpack5-loader Patch
vpssr-linaria-solid-example Patch
esbuild-example Patch
rollup-example Patch
vite-example Patch
webpack5-example Patch
@linaria/webpack-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Anber Anber force-pushed the fix/1368-space-after-function-interpolation branch from 43003c9 to 2d327ca Compare November 19, 2023 17:14
@Anber Anber merged commit faf6579 into callstack:master Nov 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants