Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace RN babel preset with codegen plugin directly #181

Merged

Conversation

jbroma
Copy link
Contributor

@jbroma jbroma commented Dec 5, 2024

PR Description

Replaced RN babel preset in the main package with codegen plugin in order to prevent injecting @babel/runtime into the code when building the release version.

This was causing issues in setup where swc is used instead of babel since swc has it's own helpers (equivalent of @babel/runtime). I believe helpers should be injected when bundling the project and not at the time of building the library, so there is no hard requirement of having @babel/runtime as a dependency in the project.

How to test?

  • - example works
  • - no warning from codegen outside the example apps

Screenshots

n/a

Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: a4da8db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
react-native-bottom-tabs Patch
@bottom-tabs/react-navigation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@okwasniewski okwasniewski merged commit 3ab7d98 into callstackincubator:main Dec 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants