Feat/track page #152
Open
Feat/track page #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 28, 2021 19:52
|
👷 Deploy request for musicritic pending review. 🔨 Explore the source changes: d26f707 |
jonathasbsouza
commented
Nov 10, 2021
jonathasbsouza
commented
Nov 10, 2021
added 9 commits
November 25, 2021 18:32
JoseRenan
reviewed
Dec 9, 2021
There was a problem hiding this comment.
Tá top, @jonathasbsouza, tá faltando só aquela mudança lá que te falei, de que o Header poderia ter mais informações que são comuns pra album e track, pra o metadata ficar só com coisas que são diferentes mesmo
| @@ -0,0 +1,50 @@ | |||
| import { Flex } from '@theme-ui/components' | |||
| import type { ThemeUIStyleObject } from 'theme-ui' | |||
| import type { PropsWithChildren } from 'hoist-non-react-statics/node_modules/@types/react' | |||
There was a problem hiding this comment.
Suggested change
| import type { PropsWithChildren } from 'hoist-non-react-statics/node_modules/@types/react' | |
| import type { PropsWithChildren } from 'react' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seja o q deus quiser